[coreboot-gerrit] [L] Change in coreboot[main]: [Squash]: Add ACPI BDAT support

[Gaggery (Code Review)]

Attention is currently required from: Anil Kumar K, Arthur Heymans, Bora Guvendik, Chen, Gang C, Cliff Huang, Jamie Ryu, Jérémy Compostella, Kane Chen, Karthik Ramasubramanian, Krishna P Bhat D, Lance Zhao, Pratikkumar V Prajapati, Ravishankar Sarawadi, Ronak Kanabar, Shuo Liu, Subrata Banik, Tim Wawrzynczak, V Sowmya, Wonkyu Kim.

Gaggery has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77255?usp=email )

Change subject: [Squash]: Add ACPI BDAT support
......................................................................

Patch Set 14:

(3 comments)

File src/soc/intel/common/block/acpi/acpi_bdat.c:

https://review.coreboot.org/c/coreboot/+/77255/comment/b8dca13e_6f3963e0 :
PS14, Line 175: 			memcpy(next_block, schema_data, data_size);
> Can we make sure in ACPI BDAT spec, all schema data are not pointers? if no pointers, the directly c […]

Regarding the spec of BDAT, the schema_data itself does not contain pointers. Please refer to memory schema 2/2B/4/4B and RMT schema 4/5. The memcpy is the efficient way to do so. Please let me know if you still have concerns.

File src/soc/intel/common/block/include/intelblocks/acpi_bdat.h:

https://review.coreboot.org/c/coreboot/+/77255/comment/c9f0add9_c093c165 :
PS14, Line 66: 	EFI_GUID schema_hob_guids[MAX_SCHEMA_LIST_LENGTH];
> Can we use base/size instead? a.k.a. […]

I'm not sure how to accommodate the code of handling ways other than hobs as I don't have a platform to test that scenario. The best way I can think of is to search for the guids in hobs, if it couldn't it form the hobs, then looking for the guids from a weak function that should be implemented by the platform code. Does it sound good? And could you please elaborate more about base/size?

https://review.coreboot.org/c/coreboot/+/77255/comment/5e93c9f0_907d6548 :
PS14, Line 67: } bdat_schema_list_hob;
> Can we rename it as bdat_schema_list? a.k.a. […]

I am not sure if the structure from non-hobs should leverage the same structure.