hsin-hsiung wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45400 )
Change subject: soc/mediatek/mt8192: add pmic MT6315 driver ......................................................................
Patch Set 20: Code-Review+1
(5 comments)
https://review.coreboot.org/c/coreboot/+/45400/1/src/soc/mediatek/mt8192/mt6... File src/soc/mediatek/mt8192/mt6315.c:
https://review.coreboot.org/c/coreboot/+/45400/1/src/soc/mediatek/mt8192/mt6... PS1, Line 212: if (pmif_arb == NULL) : pmif_arb = get_pmif_controller(PMIF_SPMI, 0);
Similar to MT6359P, I think there's no need for this.
Done
https://review.coreboot.org/c/coreboot/+/45400/1/src/soc/mediatek/mt8192/mt6... PS1, Line 324: pmif_arb
What if this is NULL?
I will call die() in get_pmif_controller().
https://review.coreboot.org/c/coreboot/+/45400/2/src/soc/mediatek/mt8192/mt6... File src/soc/mediatek/mt8192/mt6315.c:
https://review.coreboot.org/c/coreboot/+/45400/2/src/soc/mediatek/mt8192/mt6... PS2, Line 11: CPU
lowercase 'cpu'
Done
https://review.coreboot.org/c/coreboot/+/45400/2/src/soc/mediatek/mt8192/mt6... PS2, Line 106: GPU
lowercase 'gpu'
Done
https://review.coreboot.org/c/coreboot/+/45400/2/src/soc/mediatek/mt8192/mt6... PS2, Line 279: return;
No need for 'return'.
Done