Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39454 )
Change subject: soc/intel/cannonlake: Set IgdDvmt50PreAlloc accordingly to InternalGfx ......................................................................
Patch Set 1:
(6 comments)
https://review.coreboot.org/c/coreboot/+/39454/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39454/1//COMMIT_MSG@7 PS1, Line 7: accordingly according
https://review.coreboot.org/c/coreboot/+/39454/1//COMMIT_MSG@7 PS1, Line 7: soc/intel/cannonlake: Set IgdDvmt50PreAlloc accordingly to InternalGfx
soc/intel/cannonlake: Steal no memory for disabled IGD?
https://review.coreboot.org/c/coreboot/+/39454/1//COMMIT_MSG@9 PS1, Line 9: Also Why *Also*? Isn’t that implied by the first sentence.
https://review.coreboot.org/c/coreboot/+/39454/1//COMMIT_MSG@11 PS1, Line 11: 1. What does that fix? 2. Tested how?
https://review.coreboot.org/c/coreboot/+/39454/1/src/soc/intel/cannonlake/ro... File src/soc/intel/cannonlake/romstage/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/39454/1/src/soc/intel/cannonlake/ro... PS1, Line 38: m_cfg->InternalGfx = 1; With this line missing, did this work before at all?
https://review.coreboot.org/c/coreboot/+/39454/1/src/soc/intel/cannonlake/ro... PS1, Line 43: } Why does
m_cfg->InternalGfx = config->InternalGfx; m_cfg->IgdDvmt50PreAlloc = (config->InternalGfx) ? 2 : 0;
not work?