EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39352 )
Change subject: lib/spd_bin: Extend LPDDR4 SPD information
......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39352/2/src/lib/spd_bin.c
File src/lib/spd_bin.c:
https://review.coreboot.org/c/coreboot/+/39352/2/src/lib/spd_bin.c@81
PS2, Line 81: 96, 12, 24, 72 };
More stuff fits on the line above in 96 characters.
Actually I want to cut this into two equal lines. Because it too long and hard to count it.. How do you think?
https://review.coreboot.org/c/coreboot/+/39352/2/src/lib/spd_bin.c@180
PS2, Line 180: printk(BIOS_INFO, "SPD: module part number is %s\n", spd_name);
Should be a separate commit.
I am okay with this. Will do later.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39352
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I68c9782c543afab4423296fa7ac1c078db5649c3
Gerrit-Change-Number: 39352
Gerrit-PatchSet: 3
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Marco Chen
marcochen@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 06 Mar 2020 15:45:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment