Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32910 )
Change subject: src/arch/x86: Add automatic type41 entry creation
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/#/c/32910/6/src/arch/x86/smbios.c
File src/arch/x86/smbios.c:
https://review.coreboot.org/#/c/32910/6/src/arch/x86/smbios.c@1054
PS6, Line 1054: device_type == SMBIOS_DEVICE_TYPE_UNKNOWN)
please check for device_type < ARRAY_SIZE(type41_inst_cnt), too
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32910
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idcb3532a5c05666d6613af4f303df85f4f1f6e97
Gerrit-Change-Number: 32910
Gerrit-PatchSet: 7
Gerrit-Owner: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 23 May 2019 10:59:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
siro@das-labor.org
Gerrit-MessageType: comment