2 May
2021
2 May
'21
12:59 p.m.
Attention is currently required from: Kyösti Mälkki, Patrick Rudolph. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52815 )
Change subject: aopen/dxplplusu: Add early GPIO settings ......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/aopen/dxplplusu/bootblock.c:
https://review.coreboot.org/c/coreboot/+/52815/comment/a3b520c6_86ad0a56 PS1, Line 100: gpio_write(0x47, 0x86); /* LED1 invert open-drain*/ Nit: Could you please add a space before `*/`?
--
To view, visit https://review.coreboot.org/c/coreboot/+/52815
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib211e9c4b487fadec3d3487f9d745f44d8ca4579
Gerrit-Change-Number: 52815
Gerrit-PatchSet: 1
Gerrit-Owner: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Attention: Patrick Rudolph siro@das-labor.org
Gerrit-Comment-Date: Sun, 02 May 2021 12:59:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment