Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32805 )
Change subject: sdm845: Fix broken commits
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/#/c/32805/1/src/soc/qualcomm/common/Kconfig
File src/soc/qualcomm/common/Kconfig:
https://review.coreboot.org/#/c/32805/1/src/soc/qualcomm/common/Kconfig@9
PS1, Line 9: depends on SOC_QUALCOMM_COMMON
nit: should probably just use a big […]
Done
https://review.coreboot.org/#/c/32805/1/src/soc/qualcomm/common/Makefile.inc
File src/soc/qualcomm/common/Makefile.inc:
https://review.coreboot.org/#/c/32805/1/src/soc/qualcomm/common/Makefile.inc...
PS1, Line 2: romstage-$(CONFIG_SOC_QUALCOMM_COMMON_MMU) += mmu.c
No, please don't change the Makefiles. This part is intentional. Other SoCs (e.g. […]
Done.
Looks like this is the Intel way.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32805
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0195fd186ac39dd4258fe0781dd6d3d1b1d1679f
Gerrit-Change-Number: 32805
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney
mturney@codeaurora.org
Gerrit-CC: Nitheesh Sekar
nsekar@codeaurora.org
Gerrit-CC: Prudhvi Yarlagadda
pyarlaga@qualcomm.corp-partner.google.com
Gerrit-CC: SANTHOSH JANARDHANA HASSAN
sahassan@google.com
Gerrit-Comment-Date: Thu, 16 May 2019 05:14:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment
