Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31100 )
Change subject: mb/google/hatch: Set up Wake GPIO from EC
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/31100/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/31100/1//COMMIT_MSG@13
PS1, Line 13: Make sure device wakes up
Did lidopen, keyboard press also wake up the AP?
https://review.coreboot.org/#/c/31100/1/src/mainboard/google/hatch/variants/...
File src/mainboard/google/hatch/variants/baseboard/devicetree.cb:
https://review.coreboot.org/#/c/31100/1/src/mainboard/google/hatch/variants/...
PS1, Line 257: LPC Interface
Hatch actually uses eSPI.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31100
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I53d5291a6b9ab9a21e89ccd21f172180ce473bd5
Gerrit-Change-Number: 31100
Gerrit-PatchSet: 1
Gerrit-Owner: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Scott Collyer
scollyer@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 25 Jan 2019 22:52:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment