17 Aug
2020
17 Aug
'20
10:04 p.m.
chris wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43408 )
Change subject: mb/google/zork: add dptc support ......................................................................
Patch Set 11:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43408/8/src/soc/amd/picasso/acpi/dp... File src/soc/amd/picasso/acpi/dptc.asl:
https://review.coreboot.org/c/coreboot/+/43408/8/src/soc/amd/picasso/acpi/dp... PS8, Line 10: If (LEqual (_SB.PCI0.LPCB.EC0.RCTM , One)) {
Please add comments indicating what each method is for.
move this method to src/mainboard/google/zork/variants/baseboard/include/baseboard/acpi/dptc.asl and also add comment for indicate which mode used for.
--
To view, visit https://review.coreboot.org/c/coreboot/+/43408
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icae94103f254f8fdb84e6ee0f5404fb09fa97b2d
Gerrit-Change-Number: 43408
Gerrit-PatchSet: 11
Gerrit-Owner: chris wang Chris.Wang@amd.com
Gerrit-Reviewer: Chris Wang chris.wang@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Aaron Durbin adurbin@chromium.org
Gerrit-CC: Arthur Heymans arthur@aheymans.xyz
Gerrit-CC: Furquan Shaikh furquan@google.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 18 Aug 2020 01:04:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin adurbin@chromium.org
Gerrit-MessageType: comment