4 Feb
2020
4 Feb
'20
3:12 a.m.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33102 )
Change subject: ec/apple: Add ACPI code for Apple MacBooks ......................................................................
Patch Set 17:
(1 comment)
https://review.coreboot.org/c/coreboot/+/33102/17/src/ec/apple/acpi/ac.asl File src/ec/apple/acpi/ac.asl:
https://review.coreboot.org/c/coreboot/+/33102/17/src/ec/apple/acpi/ac.asl@1... PS17, Line 16:
Just to be safe: […]
Not 100% sure how iasl's message would look like, but it should result in a compile error anyway, right? if we'd literally feed `Offset(HPAC_OFFSET)` to the compiler, that's not even ASL syntax.
--
To view, visit https://review.coreboot.org/c/coreboot/+/33102
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3d4585aac8e3ebbfed6ce4d4e39fbc33ac983069
Gerrit-Change-Number: 33102
Gerrit-PatchSet: 17
Gerrit-Owner: Evgeny Zinoviev me@ch1p.io
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Evgeny Zinoviev me@ch1p.io
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 04 Feb 2020 11:12:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment