build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37858 )
Change subject: soc/fsp_broadwell_de: read SPD 3 times and pick the majority element ......................................................................
Patch Set 1:
(6 comments)
https://review.coreboot.org/c/coreboot/+/37858/1/src/soc/intel/fsp_broadwell... File src/soc/intel/fsp_broadwell_de/smbus-imc.c:
https://review.coreboot.org/c/coreboot/+/37858/1/src/soc/intel/fsp_broadwell... PS1, Line 31: for(int i = 0; i < n; i++) { space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/37858/1/src/soc/intel/fsp_broadwell... PS1, Line 33: for(int j = 0; j < n; j++) { space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/37858/1/src/soc/intel/fsp_broadwell... PS1, Line 34: if(arr[i] == arr[j]) suspect code indent for conditional statements (24, 24)
https://review.coreboot.org/c/coreboot/+/37858/1/src/soc/intel/fsp_broadwell... PS1, Line 34: if(arr[i] == arr[j]) space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/37858/1/src/soc/intel/fsp_broadwell... PS1, Line 37: if(count > maxcount) { space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/37858/1/src/soc/intel/fsp_broadwell... PS1, Line 79: if (vote(res, ARRAY_SIZE(res), &idx)) { braces {} are not necessary for single statement blocks