Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34075 )
Change subject: arch, include, soc: Use common stdint.h ......................................................................
Patch Set 5:
(3 comments)
https://review.coreboot.org/c/coreboot/+/34075/4/src/arch/arm/armv7/mmu.c File src/arch/arm/armv7/mmu.c:
https://review.coreboot.org/c/coreboot/+/34075/4/src/arch/arm/armv7/mmu.c@16... PS4, Line 168: printk(BIOS_DEBUG, "Creating new subtable @%p for [%#.8" PRIxPTR ":%#.8" PRIxPTR ")\n",
Please stick to the 80 char line length used in the rest of the file until the whole file has been c […]
The idea is that PRIxPTR is the portable way of printing a uintptr_t, since we generally cannot assume what the underlying type is. However, all architectures now use unsigned long for uintptr_t, and I don't ever see that changing in the future, so we could also just dispense with the PRI* macros for simplicity.
https://review.coreboot.org/c/coreboot/+/34075/4/src/include/stdint.h File src/include/stdint.h:
https://review.coreboot.org/c/coreboot/+/34075/4/src/include/stdint.h@105 PS4, Line 105: uint8_t
Should this be _Bool?
We'll need to make an exception for romcc since it doesn't support _Bool, but otherwise yes.
https://review.coreboot.org/c/coreboot/+/34075/4/src/soc/nvidia/tegra210/mmu... File src/soc/nvidia/tegra210/mmu_operations.c:
https://review.coreboot.org/c/coreboot/+/34075/4/src/soc/nvidia/tegra210/mmu... PS4, Line 26: uintptr_t start, end;
Why does this need to change? (I agree that it's more appropriate, but I don't think you should mix […]
memory_in_range_below_4gb() expects uintptr_t, and now that uintptr_t is unsigned long we need to update this so it compiles properly.