Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36945 )
Change subject: mb/google/kahlee/treeya: Make sure touchpad data hold time more than 300ns
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36945/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/36945/1//COMMIT_MSG@8
PS1, Line 8: than 300ns
The commit message summary must go on one line. Maybe (whatever “touchpad data hold time” is): […]
Just for the record, multi-line git subjects are well-defined. However, we generally abide by the "not more than 50 characters in the git subject" rule which pretty much makes the point moot.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36945
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idc58a595c77eba8544f27682a284be6aac5dbe25
Gerrit-Change-Number: 36945
Gerrit-PatchSet: 1
Gerrit-Owner: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 19 Nov 2019 12:35:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment