Attention is currently required from: Shelley Chen, Ravi kumar. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52371 )
Change subject: sc7280: Add GSI FW download support ......................................................................
Patch Set 14:
(11 comments)
File src/soc/qualcomm/sc7280/include/soc/qupv3_config.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120309): https://review.coreboot.org/c/coreboot/+/52371/comment/22b02d19_c26ac9b8 PS14, Line 77: { open brace '{' following struct go on the same line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120309): https://review.coreboot.org/c/coreboot/+/52371/comment/7da794d7_7e5cc948 PS14, Line 79: uint32_t iram_dword1; /* word 1 of a single IRAM firmware entry */ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120309): https://review.coreboot.org/c/coreboot/+/52371/comment/a1de59fe_c387c316 PS14, Line 83: { open brace '{' following struct go on the same line
File src/soc/qualcomm/sc7280/qupv3_config.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120309): https://review.coreboot.org/c/coreboot/+/52371/comment/25bfe665_a352701c PS14, Line 204: write32(®s->gsi_periph_base_lsb,0); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120309): https://review.coreboot.org/c/coreboot/+/52371/comment/1529fb9d_89e582fc PS14, Line 205: write32(®s->gsi_periph_base_msb,0); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120309): https://review.coreboot.org/c/coreboot/+/52371/comment/54e636cd_1af21858 PS14, Line 210: if (fwIep[i].offset < GSI_REG_BASE_SIZE) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120309): https://review.coreboot.org/c/coreboot/+/52371/comment/7457e068_7b93ab88 PS14, Line 221: memcpy((®s->gsi_inst_ramn),(void *)fwIRam, space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120309): https://review.coreboot.org/c/coreboot/+/52371/comment/6c1a2dd8_c3323603 PS14, Line 223: setbits_le32(®s->gsi_mcs_cfg, GSI_MCS_CFG_MCS_ENABLE_BMSK ); space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120309): https://review.coreboot.org/c/coreboot/+/52371/comment/139546ca_8cd03b85 PS14, Line 224: setbits_le32(®s->gsi_cfg, GSI_CFG_DOUBLE_MCS_CLK_FREQ_BMSK | GSI_CFG_GSI_ENABLE_BMSK); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120309): https://review.coreboot.org/c/coreboot/+/52371/comment/89bb08c9_96faf387 PS14, Line 226: write32(®s->gsi_ee_n_scratch_0_addr,0x0); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120309): https://review.coreboot.org/c/coreboot/+/52371/comment/ff727a10_6e4be5da PS14, Line 227: write32(®s->ee_n_gsi_ee_generic_cmd,0x81); space required after that ',' (ctx:VxV)