Attention is currently required from: Sean Rhodes, Benjamin Doron, Christian Walter, Maximilian Brune, Lean Sheng Tan.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74122 )
Change subject: [WIP] mb/prodrive/atlas: Put options in CFR cbtable ......................................................................
Patch Set 1:
(2 comments)
Patchset:
PS1:
Sheng, do we want variables for the user to control "PXE retries" and UEFI Secure Boot in the setup […]
Does it make sense to have coreboot describe these variables through CFR? If edk2 needs to read the options anyway, it might make sense to describe them in edk2 proper, and suppress them according to the profile (which can be passed via CFR).
But if the CFR parser in edk2 is separate from the handling of options themselves, then it may be simpler to declare everything through CFR. You decide, either approach is fine w.r.t coreboot side.
File src/mainboard/prodrive/atlas/cfr.c:
https://review.coreboot.org/c/coreboot/+/74122/comment/95bb85c9_298ff5f9 PS1, Line 14: struct sm_enum_value pwr_after_g3_values[] = { : { "Power on (S0)", 0 }, : { "Power off (S5)", 1 }, : SM_ENUM_VALUE_END, : };
These enum values aren't correct, see src/soc/intel/common/block/include/intelblocks/pmclib.h: […]
Done