Name of user not set #1002358 has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33234 )
Change subject: security/intel/stm: Add STM support ......................................................................
Patch Set 23:
(4 comments)
https://review.coreboot.org/c/coreboot/+/33234/23/src/security/intel/stm/Smm... File src/security/intel/stm/SmmStm.h:
https://review.coreboot.org/c/coreboot/+/33234/23/src/security/intel/stm/Smm... PS23, Line 42: * @retval INVALID_PARAMETER If nested procedure detected resource failer
'failer' may be misspelled - perhaps 'failure'?
Done
https://review.coreboot.org/c/coreboot/+/33234/23/src/security/intel/stm/Smm... File src/security/intel/stm/SmmStm.c:
https://review.coreboot.org/c/coreboot/+/33234/23/src/security/intel/stm/Smm... PS23, Line 482: * @retval INVALID_PARAMETER If nested procedure detected resource failer
'failer' may be misspelled - perhaps 'failure'?
Done
https://review.coreboot.org/c/coreboot/+/33234/23/src/security/intel/stm/Smm... PS23, Line 535: * @retval INVALID_PARAMETER If nested procedure detected resource failer
'failer' may be misspelled - perhaps 'failure'?
Done
https://review.coreboot.org/c/coreboot/+/33234/21/src/security/intel/stm/Stm... File src/security/intel/stm/StmApi.h:
https://review.coreboot.org/c/coreboot/+/33234/21/src/security/intel/stm/Stm... PS21, Line 60: uint32_t stm_smm_rev_id[1];
So I'm pretty sure this should be […]
In this case here we are depending on the [1] to define the array size correct and code that is dependent on this being so.