10 Oct
2023
10 Oct
'23
6:04 p.m.
Attention is currently required from: Martin Roth, Varshit Pandya.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78222?usp=email )
Change subject: soc/amd/genoa: Add GPIO support ......................................................................
Patch Set 8:
(1 comment)
File src/soc/amd/genoa/gpio.c:
https://review.coreboot.org/c/coreboot/+/78222/comment/0a1e013a_fff0c4ec : PS7, Line 23: { GPIO_26, GEVENT_15 },
{ GPIO_28, GEVENT_18 }, is missing. […]
i haven't seen gpio28 on the package, so i'd say that we don't add that for now
--
To view, visit https://review.coreboot.org/c/coreboot/+/78222?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I2e827e9ffbb2ec1be0f1247b77660a9fdeb04f7b
Gerrit-Change-Number: 78222
Gerrit-PatchSet: 8
Gerrit-Owner: Varshit Pandya pandyavarshit@gmail.com
Gerrit-Reviewer: Martin Roth martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Felix Held felix-coreboot@felixheld.de
Gerrit-Attention: Varshit Pandya pandyavarshit@gmail.com
Gerrit-Attention: Martin Roth martin.roth@amd.corp-partner.google.com
Gerrit-Comment-Date: Tue, 10 Oct 2023 16:04:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held felix-coreboot@felixheld.de
Gerrit-MessageType: comment