Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42469 )
Change subject: drivers/intel/mipi_camera: SSDT changes to add PLD
......................................................................
Patch Set 12: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/42469/12/src/drivers/intel/mipi_cam...
File src/drivers/intel/mipi_camera/camera.c:
https://review.coreboot.org/c/coreboot/+/42469/12/src/drivers/intel/mipi_cam...
PS12, Line 19: if (!config->pld.ignore_color)
: config->pld.ignore_color = 1;
:
: if (!config->pld.visible)
: config->pld.visible = 1;
To keep one or both of these as zero someone would have to set disable_pld_defaults to essentially d […]
Thanks for the background Matt.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42469
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If65b9cbabca95e9645d8e5023ce7fd78b0625d1e
Gerrit-Change-Number: 42469
Gerrit-PatchSet: 12
Gerrit-Owner: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Reviewer: Matt Delco
delco@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 30 Jun 2020 17:24:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Matt Delco
delco@chromium.org
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment