build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42859 )
Change subject: amdfwtool: Take a config file instead of command line parameters ......................................................................
Patch Set 65:
(5 comments)
https://review.coreboot.org/c/coreboot/+/42859/65/util/amdfwtool/amdfwtool.c File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/c/coreboot/+/42859/65/util/amdfwtool/amdfwtool.c... PS65, Line 1510: if (list_deps) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/42859/65/util/amdfwtool/data_parse.... File util/amdfwtool/data_parse.c:
https://review.coreboot.org/c/coreboot/+/42859/65/util/amdfwtool/data_parse.... PS65, Line 401: fprintf(stderr, "Modules name "%s" is not valid\n", oneline); line over 96 characters
https://review.coreboot.org/c/coreboot/+/42859/65/util/amdfwtool/data_parse.... PS65, Line 403: } else { else is not generally useful after a break or return
https://review.coreboot.org/c/coreboot/+/42859/65/util/amdfwtool/data_parse.... PS65, Line 404: if (print_deps) Too many leading tabs - consider code refactoring
https://review.coreboot.org/c/coreboot/+/42859/65/util/amdfwtool/data_parse.... PS65, Line 413: fprintf(stderr, "AMDFWTOOL config file line can't be parsed "%s"\n", oneline); line over 96 characters