Attention is currently required from: Paul Menzel, Shelley Chen.
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79854?usp=email )
Change subject: mb/google/brox: Set up FW_CONFIG
......................................................................
Patch Set 8:
(2 comments)
File src/mainboard/google/brox/variants/brox/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/79854/comment/59399493_d6caa33c :
PS1, Line 11: end
Nick, can you review these fw config settings to make sure that they cover your conerns?
It looks like they haven't decided on a camera yet?
File src/mainboard/google/brox/variants/brox/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/79854/comment/2520d273_4b2fa2ab :
PS8, Line 17: option AUDIO_UNKNOWN 0
Add:
option REALTEK_ALC256 1
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79854?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iaf43003b7e8210eee9016d779839d7048c15825f
Gerrit-Change-Number: 79854
Gerrit-PatchSet: 8
Gerrit-Owner: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nick Vaccaro
nvaccaro@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Wed, 17 Jan 2024 02:32:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Shelley Chen
shchen@google.com
Comment-In-Reply-To: Nick Vaccaro
nvaccaro@google.com
Gerrit-MessageType: comment