[coreboot-gerrit] [XS] Change in coreboot[main]: soc/intel/meteorlake: Correctly set Usb4CmMode

[Angel Pons (Code Review)]

Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Kapil Porwal, Paul Menzel, Ravishankar Sarawadi, Sean Rhodes, Subrata Banik, Tarun, Utkarsh H Patel.

Angel Pons has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/77567?usp=email )

Change subject: soc/intel/meteorlake: Correctly set Usb4CmMode
......................................................................

Patch Set 7:

(2 comments)

Patchset:

PS7:
> Could such a mismatch be detected by coreboot or the operating system, and a warning be printed?

The mismatch is within coreboot, there's no point in detecting it to print a warning (if there's such a mismatch, it means there's a bug in coreboot).

Commit Message:

https://review.coreboot.org/c/coreboot/+/77567/comment/3c6172d4_d49cbc8c?usp... :
PS7, Line 7: Correctly set Usb4CmMode
> … to SCM value

`CM` means "Connection Manager. There's two modes, FCM (Firmware Connection Manager) and SCM (Software Connection Manager). Whether to use FCM or SCM is board-specific and not user-configurable.

This patch sets the `Usb4CmMode` UPD according to the existing Kconfig option, which already adjusts the ACPI code as needed for FCM/SCM.

TL;DR: No, it sets it to FCM or SCM as per Kconfig.