Attention is currently required from: Furquan Shaikh, Angel Pons.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49213 )
Change subject: soc/intel/common/uart: Use simple(_s_) variants of PCI functions
......................................................................
Patch Set 4: Code-Review+1
(2 comments)
File src/soc/intel/common/block/uart/uart.c:
https://review.coreboot.org/c/coreboot/+/49213/comment/c2bc59dd_2fb312d8
PS4, Line 20: PCI_COMMAND_MASTER
Unrelated, this looks quite odd (without DRAM, what would a bus-master request
target?).
https://review.coreboot.org/c/coreboot/+/49213/comment/ea5c48b9_523976b1
PS4, Line 72: return 0;
This is very tricky, because `0` is a valid BDF. Please use `PCI_DEV_INVALID`.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49213
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I344037828118572ae5eb27c82c496d5e7a508a53
Gerrit-Change-Number: 49213
Gerrit-PatchSet: 4
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Fri, 08 Jan 2021 17:19:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment