Attention is currently required from: Furquan Shaikh, Angel Pons.

Patch set 4:Code-Review +1

View Change

2 comments:

• File src/soc/intel/common/block/uart/uart.c:

  • Patch Set #4, Line 20: PCI_COMMAND_MASTER

    Unrelated, this looks quite odd (without DRAM, what would a bus-master request
    target?).

  • Patch Set #4, Line 72: return 0;

    This is very tricky, because `0` is a valid BDF. Please use `PCI_DEV_INVALID`.

To view, visit change 49213. To unsubscribe, or for help writing mail filters, visit settings.