[coreboot-gerrit] Change in ...coreboot[master]: Makefile.inc: Update fsp submodule if CONFIG_USE_BLOBS

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32526 )

Change subject: Makefile.inc: Update fsp submodule if CONFIG_USE_BLOBS
......................................................................

Patch Set 1:

(1 comment)

I've just checked the FSP repo is already 75MiB of burden,
and unpredictable. So maybe the original approach was
better. But instead of adding individual platforms, we
could only check for any FSP platform?

https://review.coreboot.org/#/c/32526/1/Makefile.inc 
File Makefile.inc:

https://review.coreboot.org/#/c/32526/1/Makefile.inc@199 
PS1, Line 199: forgetthis:=$(if $(GIT),$(shell git submodule update --init --checkout 3rdparty/fsp))
Alternatively, how about condensing it to this:
    ifeq ($(CONFIG_PLATFORM_USES_FSP1_0)$(CONFIG_PLATFORM_USES_FSP1_1)$(CONFIG_PLATFORM_USES_FSP2_0),y)
    forgetthis:=$(if $(GIT),$(shell git submodule update --init --checkout 3rdparty/fsp))
    endif