Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38220 )
Change subject: sb/intel/common: Change some local SMBUS function signatures ......................................................................
Patch Set 3: Code-Review+2
(3 comments)
https://review.coreboot.org/c/coreboot/+/38220/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38220/3//COMMIT_MSG@7 PS3, Line 7: Change To be more specific, looks like the only change is using `uintptr_t` for the SMBus base address. And well, its name is made shorter.
https://review.coreboot.org/c/coreboot/+/38220/3//COMMIT_MSG@7 PS3, Line 7: SMBUS SMBus
https://review.coreboot.org/c/coreboot/+/38220/3/src/southbridge/intel/commo... File src/southbridge/intel/common/smbus.c:
https://review.coreboot.org/c/coreboot/+/38220/3/src/southbridge/intel/commo... PS3, Line 173: SMBUS_WAIT_UNTIL_ACTIVE_TIMEOUT); Many of these can be reflowed into a single line. Can be done at the end of the patchset.