[coreboot-gerrit] Change in coreboot[master]: soc/intel/common/block/acpi: Add provision for multiple PCI segments

[Usha P (Code Review)]

Usha P has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40335 )

Change subject: soc/intel/common/block/acpi: Add provision for multiple PCI segments
......................................................................

Patch Set 5:

(4 comments)

https://review.coreboot.org/c/coreboot/+/40335/4/src/soc/intel/common/block/... 
File src/soc/intel/common/block/acpi/acpi.c:

https://review.coreboot.org/c/coreboot/+/40335/4/src/soc/intel/common/block/... 
PS4, Line 38: 	uint16_t seg_nr = 0;
> agree we can avoid this as local variable

Done

https://review.coreboot.org/c/coreboot/+/40335/4/src/soc/intel/common/block/... 
PS4, Line 39: 	uint16_t pci_ex_len = (CONFIG_SA_PCIEX_LENGTH >> 20) - 1;
> > Why is the conversion needed? pci_ex_len and PCIEX_LENGTH sounds the same. […]

Done

https://review.coreboot.org/c/coreboot/+/40335/4/src/soc/intel/common/block/... 
PS4, Line 44: 		seg_nr = pci_ex_len / 256;
> make sense

Done

https://review.coreboot.org/c/coreboot/+/40335/4/src/soc/intel/common/block/... 
PS4, Line 48: 		bus_end_nr = pci_ex_len;
> make sense

Done