build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48163 )
Change subject: lenovo/g505s: add the PIRQ routing table ......................................................................
Patch Set 6:
(15 comments)
File src/mainboard/lenovo/g505s/irq_tables.c:
https://review.coreboot.org/c/coreboot/+/48163/comment/a272039a_6d711dd8 PS6, Line 22: /* bus, dev | fn, {{link, bitmap}, {link, bitmap}, {link, bitmap}, {link, bitmap} }, slot, rfu */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/48163/comment/f08f5621_308a0eac PS6, Line 24: {0x00, (0x00 << 3) | 0x2, {{0x01, 0xdc90}, {0x02, 0xdc90}, {0x03, 0xdc90}, {0x04, 0xdc90} }, 0x0, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/48163/comment/86b95f80_0bd068e7 PS6, Line 27: {0x00, (0x01 << 3) | 0x0, {{0x01, 0xdc90}, {0x02, 0xdc90}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/48163/comment/4117e4af_0ff87822 PS6, Line 29: {0x00, (0x02 << 3) | 0x0, {{0x01, 0xdc90}, {0x02, 0xdc90}, {0x03, 0xdc90}, {0x04, 0xdc90} }, 0x0, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/48163/comment/dd268bd4_56b472c4 PS6, Line 31: {0x00, (0x04 << 3) | 0x0, {{0x01, 0xdc90}, {0x02, 0xdc90}, {0x03, 0xdc90}, {0x04, 0xdc90} }, 0x0, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/48163/comment/e225d279_ee1488dc PS6, Line 33: {0x00, (0x05 << 3) | 0x0, {{0x01, 0xdc90}, {0x02, 0xdc90}, {0x03, 0xdc90}, {0x04, 0xdc90} }, 0x0, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/48163/comment/41f1f656_43ac56c3 PS6, Line 35: {0x00, (0x10 << 3) | 0x0, {{0x03, 0xdc90}, {0x00, 0x0000}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/48163/comment/6bde751e_e431f8b0 PS6, Line 37: {0x00, (0x11 << 3) | 0x0, {{0x04, 0xdc90}, {0x00, 0x0000}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/48163/comment/f994cd30_424b89da PS6, Line 40: {0x00, (0x12 << 3) | 0x0, {{0x03, 0xdc90}, {0x02, 0xdc90}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/48163/comment/153cf1cb_00eb3b80 PS6, Line 43: {0x00, (0x13 << 3) | 0x0, {{0x03, 0xdc90}, {0x02, 0xdc90}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/48163/comment/1239b7b3_f15f6de1 PS6, Line 46: {0x00, (0x16 << 3) | 0x0, {{0x03, 0xdc90}, {0x02, 0xdc90}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/48163/comment/f639f082_5e5a18da PS6, Line 49: {0x00, (0x14 << 3) | 0x0, {{0x01, 0xdc90}, {0x02, 0xdc90}, {0x03, 0xdc90}, {0x04, 0xdc90} }, 0x0, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/48163/comment/2b469043_1308223a PS6, Line 51: {0x01, (0x00 << 3) | 0x0, {{0x01, 0xdc90}, {0x02, 0xdc90}, {0x03, 0xdc90}, {0x04, 0xdc90} }, 0x1, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/48163/comment/ffe310af_ff7737f4 PS6, Line 53: {0x02, (0x00 << 3) | 0x0, {{0x01, 0xdc90}, {0x02, 0xdc90}, {0x03, 0xdc90}, {0x04, 0xdc90} }, 0x2, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/48163/comment/7c503700_8085bbb1 PS6, Line 55: {0x03, (0x00 << 3) | 0x0, {{0x02, 0xdc90}, {0x03, 0xdc90}, {0x04, 0xdc90}, {0x01, 0xdc90} }, 0x3, 0x0} line over 96 characters