Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44035 )
Change subject: sconfig: Switch to getopt
......................................................................
Patch Set 4:
I think most environments have a getopt implementation already, glibc does, freebsd does, if there are any I am unaware of that we don't and we break the environment for someone, I will be more than happy to put up a GPL'd getopt.c and add it to the makefile.
Any problems with that approach?
If in doubt, assume what other tools assume, e.g. cbfstool :)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44035
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I431633781e80362e086c000b7108191b5b01aa9d
Gerrit-Change-Number: 44035
Gerrit-PatchSet: 4
Gerrit-Owner: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 15 Sep 2020 21:18:25 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment