[coreboot-gerrit] Change in coreboot[master]: ec/lenovo/h8: Add option to set F1-F12 as primary function

[Iru Cai (vimacs) (Code Review)]

Iru Cai (vimacs) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34639 )

Change subject: ec/lenovo/h8: Add option to set F1-F12 as primary function
......................................................................

Patch Set 2:

(3 comments)

https://review.coreboot.org/c/coreboot/+/34639/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/34639/1//COMMIT_MSG@7 
PS1, Line 7: an
> The article could be removed.

Done

https://review.coreboot.org/c/coreboot/+/34639/1//COMMIT_MSG@8 
PS1, Line 8:
> How did you find this bit?

I found this in EcIoDxe in the OEM UEFI firmware image, and verified it with ectool.

https://review.coreboot.org/c/coreboot/+/34639/1/src/ec/lenovo/h8/h8.c 
File src/ec/lenovo/h8/h8.c:

https://review.coreboot.org/c/coreboot/+/34639/1/src/ec/lenovo/h8/h8.c@346 
PS1, Line 346: 		f1_to_f12_as_primary(val);
> always set this bit when a specific EC version is present?

I think it's better to add a Kconfig option as patch set 2 does.