Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42833 )
Change subject: soc/amd/picasso/soc_util: rework reduced I/O chip detection ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42833/1/src/soc/amd/picasso/soc_uti... File src/soc/amd/picasso/soc_util.c:
https://review.coreboot.org/c/coreboot/+/42833/1/src/soc/amd/picasso/soc_uti... PS1, Line 212: bool soc_is_defeatured_sku(void)
Maybe soc_has_reduced_io or soc_is_reduced_io_sku
Done, used soc_is_reduced_io_sku
https://review.coreboot.org/c/coreboot/+/42833/1/src/soc/amd/picasso/soc_uti... PS1, Line 214: SILICON_RV2
I prefer improved readability whenever possible. I don't know about the CPUID issues.
the change took a bit of a different turn as i expected, but i got rid of soc_is_dali and reworked that into soc_is_reduced_io_sku. not 100% sure if this resolves this for you though