Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30432 )
Change subject: drivers/smmstore: Fix some issues ......................................................................
Patch Set 12:
(2 comments)
https://review.coreboot.org/c/coreboot/+/30432/12/src/drivers/smmstore/store... File src/drivers/smmstore/store.c:
https://review.coreboot.org/c/coreboot/+/30432/12/src/drivers/smmstore/store... PS12, Line 58: struct region_device *rdev; This is just a pointer that is uninitialized and isn't pointing to a valid object.
https://review.coreboot.org/c/coreboot/+/30432/12/src/drivers/smmstore/store... PS12, Line 106: *rstore = *store_rdev; This will not work. The incoherent_rdev object needs to persist through the lifetime of its use. The implementation assumes it can access the outer object through the use of the embedded regino_device object. Likewise the read and write region_device objects also need to persist as the icoherent_rdev object just holds a reference to the objects themselves.
https://github.com/coreboot/coreboot/blob/master/src/commonlib/include/commo...