2 comments:
File src/drivers/smmstore/store.c:
Patch Set #12, Line 58: struct region_device *rdev;
This is just a pointer that is uninitialized and isn't pointing to a valid object.
Patch Set #12, Line 106: *rstore = *store_rdev;
This will not work. The incoherent_rdev object needs to persist through the lifetime of its use. The implementation assumes it can access the outer object through the use of the embedded regino_device object. Likewise the read and write region_device objects also need to persist as the icoherent_rdev object just holds a reference to the objects themselves.
https://github.com/coreboot/coreboot/blob/master/src/commonlib/include/commonlib/region.h#L259
To view, visit change 30432. To unsubscribe, or for help writing mail filters, visit settings.