Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32930 )
Change subject: soc/amd/common: Fix consistency in AcpiMmio arguments ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/#/c/32930/1/src/soc/amd/common/block/acpimmio/mm... File src/soc/amd/common/block/acpimmio/mmio_util.c:
https://review.coreboot.org/#/c/32930/1/src/soc/amd/common/block/acpimmio/mm... PS1, Line 147: for (i = sizeof(value) - 1 ; i >= 0 ; i--) : value = (value << 8) | biosram_read8(reg + i); While you are fixing things here, why not change this to: return biosram_read8(reg + sizeof(uint8_t)) << 8 + biosram_read8(reg);
https://review.coreboot.org/#/c/32930/1/src/soc/amd/common/block/acpimmio/mm... PS1, Line 166: for same here.
https://review.coreboot.org/#/c/32930/1/src/soc/amd/common/block/acpimmio/mm... PS1, Line 175: for and here.