[coreboot-gerrit] Change in coreboot[master]: src/soc/intel: Add support for CAR_HAS_SF_MASKS and select for TGL

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48286 )

Change subject: src/soc/intel: Add support for CAR_HAS_SF_MASKS and select for TGL
......................................................................

Patch Set 17:

(1 comment)

https://review.coreboot.org/c/coreboot/+/48286/17/src/soc/intel/common/block... 
File src/soc/intel/common/block/cpu/car/exit_car.S:

https://review.coreboot.org/c/coreboot/+/48286/17/src/soc/intel/common/block... 
PS17, Line 101: CONFIG_IA32_L3_MASK_1_DEFAULT
> Ok. […]

If you decide to drop the programming from exit car, I would recommend adding a comment here indicating why we think it is safe to do so (even though it does not match Intel programming guidelines).

Also, please wait to hear from Tim to see what he thinks about this.