Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/80416?usp=email )
Change subject: mb/google/brox: Update Verbtable for beep functionality ......................................................................
mb/google/brox: Update Verbtable for beep functionality
For boot beep functionality, relevant register values are required to be updated.
BUG=b:324528901 BRANCH=None TEST=Build & verified Boot Beep functionality on Brox
Change-Id: If236c8ac173a279db676af412377fa4e4122c1cd Signed-off-by: poornima tom poornima.tom@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/80416 Reviewed-by: Krishna P Bhat D krishna.p.bhat.d@intel.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/brox/hda_verb.c 1 file changed, 11 insertions(+), 1 deletion(-)
Approvals: Krishna P Bhat D: Looks good to me, approved build bot (Jenkins): Verified
diff --git a/src/mainboard/google/brox/hda_verb.c b/src/mainboard/google/brox/hda_verb.c index 39d2d86..bf998e1 100644 --- a/src/mainboard/google/brox/hda_verb.c +++ b/src/mainboard/google/brox/hda_verb.c @@ -6,7 +6,7 @@ /* coreboot specific header */ 0x10ec0256, // Codec Vendor / Device ID: Realtek ALC256 0x10ec12ac, // Subsystem ID - 0x0000001D, // Number of jacks (NID entries) + 0x00000013, // Number of jacks (NID entries)
AZALIA_RESET(0x1), /* NID 0x01, HDA Codec Subsystem ID Verb table */ @@ -113,6 +113,16 @@ };
const u32 pc_beep_verbs[] = { + /* Dos beep path - 1 */ + 0x01470C00, + 0x02050036, + 0x02047151, + 0x01470740, + /* Dos beep path - 2 */ + 0x0143b000, + 0x01470C02, + 0x01470C02, + 0x01470C02, };
AZALIA_ARRAY_SIZES;