Meera Ravindranath has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36067 )
Change subject: mainboard/hatch/Kconfig: Add support for boot with tianocore payload ......................................................................
Patch Set 3:
(4 comments)
https://review.coreboot.org/c/coreboot/+/36067/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36067/3//COMMIT_MSG@9 PS3, Line 9: Add new config
Why?
Boot to TianoCore requires the legacy 8254 clock gating to be disabled and the ACPI PM timer to be enabled.Hence creating this config to be able to easily provide a switch to boot TianoCore.
https://review.coreboot.org/c/coreboot/+/36067/3//COMMIT_MSG@9 PS3, Line 9: Add new config and set the required GBB flags to support boot with : tianocore payload
Please explain, why these GBB flags are required? Why can’t TianoCore be fixed?
Booting to Tianocore also requires GBB flags GBB_FLAG_ENABLE_ALTERNATE_OS and GBB_FLAG_DISABLE_EC_SOFTWARE_SYNC along with the 8254 clock gating and ACPI PM Timer
https://review.coreboot.org/c/coreboot/+/36067/3/src/mainboard/google/hatch/... File src/mainboard/google/hatch/Kconfig:
https://review.coreboot.org/c/coreboot/+/36067/3/src/mainboard/google/hatch/... PS3, Line 37: select GBB_FLAG_ENABLE_ALTERNATE_OS if BOARD_USES_TIANOCORE
Why? What does the payload have to do with the OS?
Accomodated here just to align with the other GBB flags.
https://review.coreboot.org/c/coreboot/+/36067/3/src/mainboard/google/hatch/... PS3, Line 46: select USE_ACPI_PM_TIMER
I do not think, we want such a Kconfig option. […]
Sure. Will explore that option too.