21 Apr
2023
21 Apr
'23
5:26 p.m.
Attention is currently required from: Felix Held.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74616 )
Change subject: cpu/amd/pi/00730F01/fixme: use coreboot's PCI access functions ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File src/cpu/amd/pi/00730F01/fixme.c:
https://review.coreboot.org/c/coreboot/+/74616/comment/b266193c_dbaa7221 PS1, Line 19: 0x00fedf00
Should this be changed to 0xfedf0000 for our functions? It looks like it gets fixed in the next pat […]
Nevermind, it looks like we're good.
--
To view, visit https://review.coreboot.org/c/coreboot/+/74616
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ieecc0e5f6576a838d79220b061de81e21b5d976c
Gerrit-Change-Number: 74616
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Martin Roth martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 21 Apr 2023 15:26:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Martin Roth martin.roth@amd.corp-partner.google.com
Gerrit-MessageType: comment