29 Nov
2019
29 Nov
'19
6:41 p.m.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37284 )
Change subject: mb/lenovo/t420/devicetree: Use subsystemid inheritance ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/37284/1/src/mainboard/lenovo/t420/d... File src/mainboard/lenovo/t420/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/37284/1/src/mainboard/lenovo/t420/d... PS1, Line 79: device pci 19.0 on end # Intel Gigabit Ethernet
Nit: add a space after each `on` so that all the instances of `end` are aligned
I don't see what's to do here.
--
To view, visit https://review.coreboot.org/c/coreboot/+/37284
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia321f2b974539ac1684173d767dd9eb64060364a
Gerrit-Change-Number: 37284
Gerrit-PatchSet: 1
Gerrit-Owner: Peter Lemenkov lemenkov@gmail.com
Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Peter Lemenkov lemenkov@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 29 Nov 2019 18:41:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment