Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35377 )
Change subject: lib/fmap: Cache FMAP in cbmem ......................................................................
Patch Set 7:
(3 comments)
https://review.coreboot.org/c/coreboot/+/35377/7/src/lib/fmap.c File src/lib/fmap.c:
https://review.coreboot.org/c/coreboot/+/35377/7/src/lib/fmap.c@42 PS7, Line 42: if (cbmem_possibly_online()) { I don't think this check is necessary as the size check below should always work.
https://review.coreboot.org/c/coreboot/+/35377/7/src/lib/fmap.c@45 PS7, Line 45: fmap_cache just use car_get_var(&fmap_cache);
https://review.coreboot.org/c/coreboot/+/35377/7/src/lib/fmap.c@223 PS7, Line 223: mdev Why can't we use the global directly? I don't understand why we'd be copying objects from local to global.