Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34777 )
Change subject: mediatek/mt8183: postpone dcxo low power mode setting ......................................................................
Patch Set 1: Code-Review+2
(2 comments)
https://review.coreboot.org/c/coreboot/+/34777/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34777/1//COMMIT_MSG@11 PS1, Line 11: We should not disable XO_CEL and block the bblpm request when MD is still ON. nit: I have no idea what this means. What is "MD"? Please be a little more elaborate.
https://review.coreboot.org/c/coreboot/+/34777/1/src/soc/mediatek/mt8183/inc... File src/soc/mediatek/mt8183/include/soc/rtc.h:
https://review.coreboot.org/c/coreboot/+/34777/1/src/soc/mediatek/mt8183/inc... PS1, Line 222: void dcxo_disable_unused(void); nit: external functions should be better namespaced, e.g. rtc_dcxo_disable_unused() or mt6358_dcxo_disable_unused(). (What does "unused" even mean here? Name could be more descriptive.)