Patch set 1:Code-Review +2
2 comments:
Patch Set #1, Line 11: We should not disable XO_CEL and block the bblpm request when MD is still ON.
nit: I have no idea what this means. What is "MD"? Please be a little more elaborate.
File src/soc/mediatek/mt8183/include/soc/rtc.h:
Patch Set #1, Line 222: void dcxo_disable_unused(void);
nit: external functions should be better namespaced, e.g. rtc_dcxo_disable_unused() or mt6358_dcxo_disable_unused(). (What does "unused" even mean here? Name could be more descriptive.)
To view, visit change 34777. To unsubscribe, or for help writing mail filters, visit settings.