Attention is currently required from: Jason Glenesk, Raul Rangel, Matt DeVillier, Fred Reitberger, Felix Held.
Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/69532 )
Change subject: [WIP] ACPI MADT: Drop acpi_fill_madt() under platforms ......................................................................
[WIP] ACPI MADT: Drop acpi_fill_madt() under platforms
Change-Id: Ia0614d78da2ba6c1eba48e1877b50b45a5f3cb88 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- D src/mainboard/aopen/dxplplusu/acpi_tables.c D src/mainboard/emulation/qemu-i440fx/acpi_tables.c M src/northbridge/amd/pi/00730F01/Makefile.inc D src/northbridge/amd/pi/00730F01/acpi_tables.c M src/soc/amd/cezanne/acpi.c M src/soc/amd/glinda/acpi.c M src/soc/amd/mendocino/acpi.c M src/soc/amd/morgana/acpi.c M src/soc/amd/picasso/acpi.c M src/soc/amd/stoneyridge/acpi.c M src/soc/intel/baytrail/acpi.c M src/soc/intel/braswell/acpi.c D src/southbridge/intel/common/madt.c M src/southbridge/intel/i82801gx/lpc.c M src/southbridge/intel/i82801ix/Makefile.inc D src/southbridge/intel/i82801ix/madt.c M src/southbridge/intel/i82801jx/lpc.c M src/southbridge/intel/ibexpeak/Makefile.inc D src/southbridge/intel/ibexpeak/madt.c 19 files changed, 10 insertions(+), 218 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/69532/1
diff --git a/src/mainboard/aopen/dxplplusu/acpi_tables.c b/src/mainboard/aopen/dxplplusu/acpi_tables.c deleted file mode 100644 index d7827aa..0000000 --- a/src/mainboard/aopen/dxplplusu/acpi_tables.c +++ /dev/null @@ -1,13 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -#include <acpi/acpi.h> - -unsigned long acpi_fill_madt(unsigned long current) -{ - current = acpi_create_madt_lapics_with_nmis(current); - - /* Southbridge IOAPIC */ - current = acpi_create_madt_ioapics_from_list(current); - - return current; -} diff --git a/src/mainboard/emulation/qemu-i440fx/acpi_tables.c b/src/mainboard/emulation/qemu-i440fx/acpi_tables.c deleted file mode 100644 index e2b5439..0000000 --- a/src/mainboard/emulation/qemu-i440fx/acpi_tables.c +++ /dev/null @@ -1,20 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -#include <acpi/acpi.h> -#include <arch/ioapic.h> -#include <arch/smp/mpspec.h> -#include <device/device.h> - -#include "fw_cfg.h" -#include "acpi.h" - -unsigned long acpi_fill_madt(unsigned long current) -{ - /* Local APICs */ - current = acpi_create_madt_lapics_with_nmis(current); - - /* IOAPIC */ - current = acpi_create_madt_ioapics_from_list(current); - - return current; -} diff --git a/src/northbridge/amd/pi/00730F01/Makefile.inc b/src/northbridge/amd/pi/00730F01/Makefile.inc index 8fc4ffc..b97b335 100644 --- a/src/northbridge/amd/pi/00730F01/Makefile.inc +++ b/src/northbridge/amd/pi/00730F01/Makefile.inc @@ -4,7 +4,6 @@
ramstage-y += northbridge.c ramstage-y += iommu.c -ramstage-y += acpi_tables.c
romstage-y += state_machine.c ramstage-y += state_machine.c diff --git a/src/northbridge/amd/pi/00730F01/acpi_tables.c b/src/northbridge/amd/pi/00730F01/acpi_tables.c deleted file mode 100644 index 612d3f0..0000000 --- a/src/northbridge/amd/pi/00730F01/acpi_tables.c +++ /dev/null @@ -1,15 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -#include <acpi/acpi.h> -#include <arch/ioapic.h> - -unsigned long acpi_fill_madt(unsigned long current) -{ - /* create all subtables for processors */ - current = acpi_create_madt_lapics_with_nmis(current); - - /* all IOAPICs */ - current = acpi_create_madt_ioapics_from_list(current); - - return current; -} diff --git a/src/soc/amd/cezanne/acpi.c b/src/soc/amd/cezanne/acpi.c index b6c55ff..f99ef76 100644 --- a/src/soc/amd/cezanne/acpi.c +++ b/src/soc/amd/cezanne/acpi.c @@ -21,16 +21,6 @@ #include <types.h> #include "chip.h"
-unsigned long acpi_fill_madt(unsigned long current) -{ - /* create all subtables for processors */ - current = acpi_create_madt_lapics_with_nmis(current); - - current = acpi_create_madt_ioapics_from_list(current); - - return current; -} - /* * Reference section 5.2.9 Fixed ACPI Description Table (FADT) * in the ACPI 3.0b specification. diff --git a/src/soc/amd/glinda/acpi.c b/src/soc/amd/glinda/acpi.c index edb1136..c52efb3 100644 --- a/src/soc/amd/glinda/acpi.c +++ b/src/soc/amd/glinda/acpi.c @@ -24,16 +24,6 @@ #include <types.h> #include "chip.h"
-unsigned long acpi_fill_madt(unsigned long current) -{ - /* create all subtables for processors */ - current = acpi_create_madt_lapics_with_nmis(current); - - current = acpi_create_madt_ioapics_from_list(current); - - return current; -} - /* * Reference section 5.2.9 Fixed ACPI Description Table (FADT) * in the ACPI 3.0b specification. diff --git a/src/soc/amd/mendocino/acpi.c b/src/soc/amd/mendocino/acpi.c index 03d9e05..62769f14 100644 --- a/src/soc/amd/mendocino/acpi.c +++ b/src/soc/amd/mendocino/acpi.c @@ -23,16 +23,6 @@ #include <types.h> #include "chip.h"
-unsigned long acpi_fill_madt(unsigned long current) -{ - /* create all subtables for processors */ - current = acpi_create_madt_lapics_with_nmis(current); - - current = acpi_create_madt_ioapics_from_list(current); - - return current; -} - /* * Reference section 5.2.9 Fixed ACPI Description Table (FADT) * in the ACPI 3.0b specification. diff --git a/src/soc/amd/morgana/acpi.c b/src/soc/amd/morgana/acpi.c index 246676f..7b61021 100644 --- a/src/soc/amd/morgana/acpi.c +++ b/src/soc/amd/morgana/acpi.c @@ -24,16 +24,6 @@ #include <types.h> #include "chip.h"
-unsigned long acpi_fill_madt(unsigned long current) -{ - /* create all subtables for processors */ - current = acpi_create_madt_lapics_with_nmis(current); - - current = acpi_create_madt_ioapics_from_list(current); - - return current; -} - /* * Reference section 5.2.9 Fixed ACPI Description Table (FADT) * in the ACPI 3.0b specification. diff --git a/src/soc/amd/picasso/acpi.c b/src/soc/amd/picasso/acpi.c index da2ed74..bcd4171 100644 --- a/src/soc/amd/picasso/acpi.c +++ b/src/soc/amd/picasso/acpi.c @@ -28,16 +28,6 @@ #include <version.h> #include "chip.h"
-unsigned long acpi_fill_madt(unsigned long current) -{ - /* create all subtables for processors */ - current = acpi_create_madt_lapics_with_nmis(current); - - current = acpi_create_madt_ioapics_from_list(current); - - return current; -} - /* * Reference section 5.2.9 Fixed ACPI Description Table (FADT) * in the ACPI 3.0b specification. diff --git a/src/soc/amd/stoneyridge/acpi.c b/src/soc/amd/stoneyridge/acpi.c index 641c9c4..e8e782d 100644 --- a/src/soc/amd/stoneyridge/acpi.c +++ b/src/soc/amd/stoneyridge/acpi.c @@ -23,16 +23,6 @@ #include <soc/gpio.h> #include <version.h>
-unsigned long acpi_fill_madt(unsigned long current) -{ - /* create all subtables for processors */ - current = acpi_create_madt_lapics_with_nmis(current); - - current = acpi_create_madt_ioapics_from_list(current); - - return current; -} - /* * Reference section 5.2.9 Fixed ACPI Description Table (FADT) * in the ACPI 3.0b specification. diff --git a/src/soc/intel/baytrail/acpi.c b/src/soc/intel/baytrail/acpi.c index 053e6e3..081d5ed 100644 --- a/src/soc/intel/baytrail/acpi.c +++ b/src/soc/intel/baytrail/acpi.c @@ -98,23 +98,6 @@ override->flags = MP_IRQ_TRIGGER_LEVEL | MP_IRQ_POLARITY_HIGH; }
-unsigned long acpi_fill_madt(unsigned long current) -{ - /* Local APICs */ - current = acpi_create_madt_lapics_with_nmis(current); - - /* IOAPIC */ - - _override[2]; - const irq_overrides_dyn = { &_override, ARRAY_SIZE(_override) }; - - fill_pit_override(&_override[0]); - fill_sci_override(&_override[1]); - current = acpi_create_madt_ioapic_gsi0(current, &irq_overrides_dyn); - - return current; -} - static acpi_tstate_t soc_tss_table[] = { { 100, 1000, 0, 0x00, 0 }, { 88, 875, 0, 0x1e, 0 }, diff --git a/src/soc/intel/braswell/acpi.c b/src/soc/intel/braswell/acpi.c index 5b78539..05272f1 100644 --- a/src/soc/intel/braswell/acpi.c +++ b/src/soc/intel/braswell/acpi.c @@ -317,21 +317,6 @@ override->flags = MP_IRQ_TRIGGER_LEVEL | MP_IRQ_POLARITY_HIGH; }
-unsigned long acpi_fill_madt(unsigned long current) -{ - /* Local APICs */ - current = acpi_create_madt_lapics_with_nmis(current); - - /* IOAPIC */ - _override[2]; - const irq_overrides_dyn = { &_override, ARRAY_SIZE(_override) }; - fill_pit_override(&_override[0]); - fill_sci_override(&_override[1]); - current = acpi_create_madt_ioapic_gsi0(current, &irq_overrides_dyn); - - return current; -} - unsigned long southcluster_write_acpi_tables(const struct device *device, unsigned long current, struct acpi_rsdp *rsdp) { diff --git a/src/southbridge/intel/common/madt.c b/src/southbridge/intel/common/madt.c deleted file mode 100644 index 90876aa..0000000 --- a/src/southbridge/intel/common/madt.c +++ /dev/null @@ -1,16 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -#include <acpi/acpi.h> -#include <arch/ioapic.h> -#include <arch/smp/mpspec.h> - -unsigned long acpi_fill_madt(unsigned long current) -{ - /* Local APICs */ - current = acpi_create_madt_lapics_with_nmis(current); - - /* IOAPIC */ - current = acpi_create_madt_ioapic_default_gsi0(current); - - return current; -} diff --git a/src/southbridge/intel/i82801gx/lpc.c b/src/southbridge/intel/i82801gx/lpc.c index 1d79d2f..7d2c73f 100644 --- a/src/southbridge/intel/i82801gx/lpc.c +++ b/src/southbridge/intel/i82801gx/lpc.c @@ -349,17 +349,6 @@ i82801gx_fixups(dev); }
-unsigned long acpi_fill_madt(unsigned long current) -{ - /* Local APICs */ - current = acpi_create_madt_lapics_with_nmis(current); - - /* IOAPIC */ - current = acpi_create_madt_ioapics_from_list(current); - - return current; -} - static void i82801gx_lpc_read_resources(struct device *dev) { struct resource *res; diff --git a/src/southbridge/intel/i82801ix/Makefile.inc b/src/southbridge/intel/i82801ix/Makefile.inc index 0000913..8db30ad 100644 --- a/src/southbridge/intel/i82801ix/Makefile.inc +++ b/src/southbridge/intel/i82801ix/Makefile.inc @@ -22,10 +22,6 @@
smm-y += smihandler.c
-ifneq ($(CONFIG_BOARD_EMULATION_QEMU_X86_Q35),y) -ramstage-y += madt.c -endif - CPPFLAGS_common += -I$(src)/southbridge/intel/i82801ix/include
endif diff --git a/src/southbridge/intel/i82801ix/madt.c b/src/southbridge/intel/i82801ix/madt.c deleted file mode 100644 index b7f3581..0000000 --- a/src/southbridge/intel/i82801ix/madt.c +++ /dev/null @@ -1,16 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -#include <acpi/acpi.h> -#include <arch/ioapic.h> -#include <arch/smp/mpspec.h> - -unsigned long acpi_fill_madt(unsigned long current) -{ - /* Local APICs */ - current = acpi_create_madt_lapics_with_nmis(current); - - /* IOAPIC */ - current = acpi_create_madt_ioapics_from_list(current); - - return current; -} diff --git a/src/southbridge/intel/i82801jx/lpc.c b/src/southbridge/intel/i82801jx/lpc.c index 77cb139..9899474 100644 --- a/src/southbridge/intel/i82801jx/lpc.c +++ b/src/southbridge/intel/i82801jx/lpc.c @@ -364,17 +364,6 @@ i82801jx_set_acpi_mode(dev); }
-unsigned long acpi_fill_madt(unsigned long current) -{ - /* Local APICs */ - current = acpi_create_madt_lapics_with_nmis(current); - - /* IOAPIC */ - current = acpi_create_madt_ioapics_from_list(current); - - return current; -} - static void i82801jx_lpc_read_resources(struct device *dev) { int i, io_index = 0; diff --git a/src/southbridge/intel/ibexpeak/Makefile.inc b/src/southbridge/intel/ibexpeak/Makefile.inc index 1cf3d1c..8b059e7 100644 --- a/src/southbridge/intel/ibexpeak/Makefile.inc +++ b/src/southbridge/intel/ibexpeak/Makefile.inc @@ -20,7 +20,6 @@ ramstage-y += ../bd82x6x/me_status.c
ramstage-$(CONFIG_ELOG) += ../bd82x6x/elog.c -ramstage-y += madt.c
smm-y += smihandler.c
diff --git a/src/southbridge/intel/ibexpeak/madt.c b/src/southbridge/intel/ibexpeak/madt.c deleted file mode 100644 index 8e2211a..0000000 --- a/src/southbridge/intel/ibexpeak/madt.c +++ /dev/null @@ -1,18 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -#include <arch/ioapic.h> -#include <acpi/acpi.h> -#include <arch/smp/mpspec.h> -#include <device/device.h> -#include <device/pci.h> - -unsigned long acpi_fill_madt(unsigned long current) -{ - /* Local APICs */ - current = acpi_create_madt_lapics_with_nmis(current); - - /* IOAPIC */ - current = acpi_create_madt_ioapics_from_list(current); - - return current; -}