Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36000 )
Change subject: vendorcode/amd/agesa/f12/Proc/CPU: Fix set MTRR6 and MTRR7 to default ......................................................................
Patch Set 2:
Patch Set 2:
Patch Set 2:
I think it is better to test this on hardware
FWIW, this effort was spawned by a mailing list thread wanting AGESA cleanup due to hte quantity of Coverity issues: https://www.mail-archive.com/coreboot@coreboot.org/msg54032.html. I have access to only one of the models in question, so won't be able to test the majority of corrections on actual hardware. How would it be best to proceed?
If you find similar issues across multiple AGESA platforms of which you can only test one, you can have a reasonable expectation that it will work for others too. Otherwise you can always ask on the mailing list for tests, assuming there is no maintainer for these platforms anymore. If after a sufficiently long time no-one seems interested, it might be better to simply drop the platform.