Attention is currently required from: Evgeny Zinoviev. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37115 )
Change subject: sb/intel/bd82x6x: Support ME Soft Temporary Disable Mode ......................................................................
Patch Set 25:
(4 comments)
File src/southbridge/intel/bd82x6x/me.c:
https://review.coreboot.org/c/coreboot/+/37115/comment/6f4b25b1_f89c015a PS25, Line 282: : /* Put ME in Software Temporary Disable Mode, if needed */ : if (me_state == CMOS_ME_STATE_DISABLED : && CMOS_ME_STATE(me_state_prev) == CMOS_ME_STATE_NORMAL) { : printk(BIOS_INFO, "ME: disabling ME\n"); : if (enter_soft_temp_disable()) { : enter_soft_temp_disable_wait(); : need_reset = true; : } else { : printk(BIOS_ERR, "ME: failed to enter Soft Temporary Disable mode\n"); : } : : break; : } Would it make sense to print the capabilities before switching to soft temporary disable mode?
https://review.coreboot.org/c/coreboot/+/37115/comment/1a754267_e9ea5904 PS25, Line 322: /* : * ME starts loading firmware immediately after writing to H_GS, : * but Lenovo BIOS performs a reboot after bringing ME back to : * Normal mode. Assume that global reset is needed. : */ On later ME firmware versions, there's a SET ME ENABLE RESPONSE message that should be read from the MEI circular buffer
File src/southbridge/intel/bd82x6x/me_common.c:
https://review.coreboot.org/c/coreboot/+/37115/comment/10df4b1a_a53bae83 PS25, Line 467: 0x20000000 0x2 << 28
File src/southbridge/intel/ibexpeak/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/37115/comment/3a304061_7d142f3a PS25, Line 33: romstage-y +=../bd82x6x/me_common.c aaaaaargh! can we avoid this?