[coreboot-gerrit] Change in coreboot[master]: soc/amd/common: Separate single GPIO programming

[Kyösti Mälkki (Code Review)]

Attention is currently required from: Raul Rangel.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42807 )

Change subject: soc/amd/common: Separate single GPIO programming
......................................................................

Patch Set 10:

(3 comments)

File src/soc/amd/common/block/gpio_banks/gpio.c:

https://review.coreboot.org/c/coreboot/+/42807/comment/a67a4ff6_05288835 
PS1, Line 203: gpio_list_ptr
> See CB:42691 […]

Ack

https://review.coreboot.org/c/coreboot/+/42807/comment/75a1fbd6_7e1e89eb 
PS1, Line 203: set_single_gpio
> How about program_gpio

While true, I also find it visually too much like program_gpios.

File src/soc/amd/common/block/gpio_banks/gpio.c:

https://review.coreboot.org/c/coreboot/+/42807/comment/aba70dbc_9cca9452 
PS2, Line 251: 					 &sci_trigger_cfg);
> *sigh* drop &

Ack