Akshu Agrawal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30724 )
Change subject: drivers/generic/adau7002: Add wakeup-delay-ms property ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/30724/1/src/drivers/generic/adau7002/adau700... File src/drivers/generic/adau7002/adau7002.c:
https://review.coreboot.org/#/c/30724/1/src/drivers/generic/adau7002/adau700... PS1, Line 32: dev->chip_info;
if dev == NULL, you already crashed here... […]
It's possible to have dev-> config NULL, so will have a check if (!dev || !dev->enabled || !dev->config) ... and then assign config = dev->config;
https://review.coreboot.org/#/c/30724/1/src/drivers/generic/adau7002/adau700... PS1, Line 53: /* This points to the first pin in the first gpio entry in _CRS */
huh?
Will remove it. Residue form initial version where I was adding GPIO also along with wake-delay but later realized adau7002 does not have GPIO to turn ON/OFF but uses BCLK.