Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33844 )
Change subject: src/security/vboot: Add config option to skip display init ......................................................................
Patch Set 1:
(3 comments)
LGTM other than some wording cleanup
https://review.coreboot.org/#/c/33844/1/src/security/vboot/Kconfig File src/security/vboot/Kconfig:
https://review.coreboot.org/#/c/33844/1/src/security/vboot/Kconfig@172 PS1, Line 172: config VBOOT_MUST_REQUEST_DISPLAY nit: maybe move it right above this option because they're related to the same thing
https://review.coreboot.org/#/c/33844/1/src/security/vboot/Kconfig@177 PS1, Line 177: Set this option to indicate to vboot that this platform will skip its Should update this text to clarify this only happens when MAY_SKIP_DISPLAY_INIT is set. (We could also declare a formal 'depends on', although it wouldn't really do anything other than document the intended relationship because this is meant to be selected by mainboards and that overrides depends anyway.)
https://review.coreboot.org/#/c/33844/1/src/security/vboot/Kconfig@244 PS1, Line 244: CHROMEOS The option isn't really CHROMEOS specific so this text shouldn't mention it -- it makes sense for any platform that has no firmware UI other than for vboot special cases. I'd maybe say something like
Set this option to indicate that coreboot should skip display initialization on a normal (non-recovery, non-developer) boot. This is useful for platforms that don't have firmware UI in normal mode.