Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39178 )
Change subject: sb/amd: Move smbus to common place ......................................................................
Patch Set 9: Code-Review+1
(3 comments)
https://review.coreboot.org/c/coreboot/+/39178/7/src/southbridge/amd/agesa/h... File src/southbridge/amd/agesa/hudson/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/39178/7/src/southbridge/amd/agesa/h... PS7, Line 5: romstage-y += smbus_spd.c ../../common/smbus.c
why I use an option that will be selected every time?
What if somebody decides to rename smbus.c to something else? You would have to change it multiple times...
https://review.coreboot.org/c/coreboot/+/39178/7/src/southbridge/amd/agesa/h... File src/southbridge/amd/agesa/hudson/hudson.c:
https://review.coreboot.org/c/coreboot/+/39178/7/src/southbridge/amd/agesa/h... PS7, Line 26: #include "southbridge/amd/common/smbus.h"
Done
Sorry, forgot to mention: since these files have the <foobar.h> includes first, and then the "foobar.h" includes, this line should go up.
Yes, there's an exception here and there, but let's not add more if we can :)
https://review.coreboot.org/c/coreboot/+/39178/7/src/southbridge/amd/cimx/sb... File src/southbridge/amd/cimx/sb800/smbus.c:
PS7:
yes it is, if we remove the BIOS_DEBUG printk ...
Ack