Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41621 )
Change subject: mb/asrock/e350m1/buildOpts.c: Fix AGESA_VERSION_STRING
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41621/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/41621/1//COMMIT_MSG@10
PS1, Line 10: Change it so that it matches the other AGESA f14 boards in the tree.
What for? One might as well check the changed values in the single line this commit modifies. […]
The commit message is one way during review to verify the diff. A few errors where already found during review, where the values in the commit message and the diff differed, and could be fixed then.
Currently, reviewers have to open other files in the tree to verify the version number you put in.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41621
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I384bd96db51457e68a320b99ecdbb2ada0dfbdd5
Gerrit-Change-Number: 41621
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Reviewer: Michal Zygowski
miczyg94@gmail.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Mike Banon
mikebdp2@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 23 May 2020 19:46:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment