Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/80569?usp=email )
(
2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: mb/google/rex/var/deku: Correct GPIO F19/F20 to not connected ......................................................................
mb/google/rex/var/deku: Correct GPIO F19/F20 to not connected
GPP_F19 and GPP_F20 sre set incorrectly previously. Change them to not connected according to schematics.
BUG=b:305793886 TEST=Built FW image correctly.
Change-Id: Ifb6da1f8696f44cb47be3d1de83c55e62b12a9e9 Signed-off-by: Eran Mitrani mitrani@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/80569 Reviewed-by: Kapil Porwal kapilporwal@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Subrata Banik subratabanik@google.com Reviewed-by: Eric Lai ericllai@google.com --- M src/mainboard/google/rex/variants/deku/gpio.c 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Eric Lai: Looks good to me, approved Kapil Porwal: Looks good to me, approved Subrata Banik: Looks good to me, approved
diff --git a/src/mainboard/google/rex/variants/deku/gpio.c b/src/mainboard/google/rex/variants/deku/gpio.c index 9aa5900..1c5e629 100644 --- a/src/mainboard/google/rex/variants/deku/gpio.c +++ b/src/mainboard/google/rex/variants/deku/gpio.c @@ -264,9 +264,9 @@ /* GPP_F18 : net NC is not present in the given design */ PAD_NC(GPP_F18, NONE), /* GPP_F19 : [GPP_F19_STRAP] ==> Component NC */ - PAD_CFG_NF(GPP_F19, NONE, DEEP, NF1), + PAD_NC(GPP_F19, NONE), /* GPP_F20 : [GPP_F20_STRAP] ==> Component NC */ - PAD_CFG_NF(GPP_F20, NONE, DEEP, NF1), + PAD_NC(GPP_F20, NONE), /* GPP_F21 : [GPP_F21_STRAP] ==> Component NC */ PAD_NC(GPP_F21, NONE), /* GPP_F22 : [] ==> GPP_F22_ISH_GP8A */